Update data and tets for iso-codes 4.8.0 #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data update means AL data no longer has subdivisions within subdivisions. Switch to FR which does.
The names 'England' and 'England and Wales' no longer appear in the data setso update the test to use NL data with similar properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a data update for
pycountryto match the updated data ofiso-codesversion 4.8.0, released Nov 2021.The PR:
Some of the test updates are simply updating the expected results while others switch the query to a different jurisdiction as data changes have removed the necessary information.
Thanks for maintaining
pycountry!Closes: #85