Vasilis/policy #377
Merged
Vasilis/policy #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moprescu
approved these changes
Mar 18, 2021
econml/policy/forest/_forest.py
Outdated
| # ============================================================================= | ||
|
|
||
|
|
||
| class PolicyForest(BaseEnsemble, metaclass=ABCMeta): |
There was a problem hiding this comment.
Same here, a lot of similarities with the GRF forest, except that the GRF has a lot more auxiliary functions (about 2/3 of the code). Most of the components here appear in the GRF forest as well.
There was a problem hiding this comment.
I tried for this one, but there was so much different small details that I thought it was ok for the forest.
I merged them in the tree, but left the forests separate.
heimengqi
approved these changes
Mar 19, 2021
kbattocchi
reviewed
Mar 19, 2021
|
Shouldn't the new policy files also be added to our documentation? |
…ed notebooks. changed formating of text in tree plotting
done! Added the autosummary for the policy moduel |
kbattocchi
reviewed
Mar 20, 2021
kbattocchi
approved these changes
Mar 20, 2021
…mes when none is passed in drlearner
… to non-fixed-randomness behavior
heimengqi
reviewed
Mar 22, 2021
kbattocchi
reviewed
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added policy module.
Enabled policy interpreter for multiple treatments using a custom policy tree.
Add doubly robust forest policy learner.