Skip to content

Alternative scoring metrics - signoff on clean branch no rebase #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2025
Merged

Alternative scoring metrics - signoff on clean branch no rebase #988

merged 2 commits into from
Jul 9, 2025

Conversation

carl-offerfit
Copy link
Contributor

@carl-offerfit carl-offerfit commented Jul 9, 2025 •
edited
Loading

  • Allow specification of an alternative sklearn score function for double ML models
  • Add score_nuisances function
  • All the changes to a clean branch from main, comitted with --signoff

@carl-offerfit carl-offerfit changed the title All the changes to a clean branch from main, comitted with --signoff Alternative scoring metrics Jul 9, 2025
@carl-offerfit carl-offerfit changed the title Alternative scoring metrics Alternative scoring metrics - signoff on clean branch no rebase Jul 9, 2025
@carl-offerfit
Copy link
Contributor Author

@kbattocchi I made this branch using a clean branch and the signoff, without rebasing. Hopefully this is good.

@kbattocchi
All the changes to a clean branch from main, comitted with --signoff
889b1a3 
Signed-off-by: Carl Gold <carl.goldd@braze.com>
@kbattocchi kbattocchi force-pushed the carl/metrics-take3 branch from 2836dc1 to 889b1a3 Compare July 9, 2025 18:17
@kbattocchi
Fix docstring errors
3b15e09 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
kbattocchi
kbattocchi approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for sticking with it! I've rebased onto the latest updates to main and fixed a resulting docstring issue. Once the tests pass I'll merge it in.

@kbattocchi kbattocchi enabled auto-merge (squash) July 9, 2025 20:12
@kbattocchi kbattocchi mentioned this pull request Jul 9, 2025
Closed
@kbattocchi kbattocchi merged commit 06bb009 into py-why:main Jul 9, 2025
193 of 196 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carl-offerfit @kbattocchi