Skip to content

Conversation

kbattocchi
Copy link
Collaborator

No description provided.

@kbattocchi kbattocchi requested a review from fverac June 27, 2025 15:39
@kbattocchi kbattocchi force-pushed the kebatt/updateBuildProcess branch from 47e2645 to 2ebd123 Compare June 27, 2025 15:46
@fverac
Copy link
Collaborator

fverac commented Jun 27, 2025

DeepIV is still mentioned on the "Library Flow Chart" image, though not sure how easy that is to change..

@fverac
Copy link
Collaborator

fverac commented Jun 27, 2025

Probably also worth removing doc\spec\estimation\deepiv.rst

kbattocchi and others added 3 commits July 3, 2025 13:17
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
They are read-only in modern numpy

Signed-off-by: bluedrink9 <26474254+BlueDrink9@users.noreply.github.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
@kbattocchi kbattocchi force-pushed the kebatt/updateBuildProcess branch 2 times, most recently from 1e44810 to ec9e0d8 Compare July 4, 2025 00:19
@kbattocchi kbattocchi marked this pull request as ready for review July 4, 2025 00:19
@kbattocchi
Copy link
Collaborator Author

kbattocchi commented Jul 4, 2025

@fverac :

DeepIV is still mentioned on the "Library Flow Chart" image, though not sure how easy that is to change..

Probably also worth removing doc\spec\estimation\deepiv.rst

Good catches, both addressed in latest set of changes.

Copy link
Collaborator

@fverac fverac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made some comments earlier in this PR thread, curious to hear your thoughts there.

Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
This reverts commit eb5e1d3.

Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
@kbattocchi kbattocchi force-pushed the kebatt/updateBuildProcess branch from ec9e0d8 to a3c75db Compare July 8, 2025 16:49
@kbattocchi kbattocchi merged commit 641c1ac into main Jul 8, 2025
196 of 199 checks passed
@kbattocchi kbattocchi deleted the kebatt/updateBuildProcess branch July 8, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants