ENH: _check_sample_weight dtype made kwarg in sklearn 1.7.x
#980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atharva Kelkar <akelkar@novilabs.com>
5e7cb3d to
047dbaa
Compare
fverac
approved these changes
Jun 30, 2025
carl-offerfit
pushed a commit
to carl-offerfit/EconML
that referenced
this pull request
Jul 7, 2025
Signed-off-by: Atharva Kelkar <akelkar@novilabs.com> Signed-off-by: Carl Gold <carl.goldd@braze.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
EconMLtreatsDOUBLEas a positional argument in_check_sample_weight. This is incompatible with the latest version ofscikit-learn(1.7.0), wheredtypehas been made a positional argument [ref]. This PR makes passesDOUBLEas a named argument (dtype) to_check_sample_weight.