Skip to content

Conversation

KuanHaoHuang
Copy link
Contributor

Fixed two typos to make this case study more readable:

  • "indentify" -> "identify"
  • sample_treatment_cast -> sample_treatment_costs

@fverac
Copy link
Collaborator

fverac commented Mar 20, 2025

Thanks for the PR! changes look straightforward. The DCO check is failing, can you sign your commit based on the instructions here?

https://github.com/py-why/EconML/pull/957/checks?check_run_id=39096372221

Signed-off-by: Kuan-Hao Huang <kuan.hao.huang.b02@gmail.com>
@KuanHaoHuang
Copy link
Contributor Author

Thanks for the heads-up. Just signed it.

Copy link
Collaborator

@fverac fverac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@fverac fverac merged commit 7b08a47 into py-why:main Mar 21, 2025
15 checks passed
carl-offerfit pushed a commit to carl-offerfit/EconML that referenced this pull request Mar 31, 2025
Signed-off-by: Kuan-Hao Huang <kuan.hao.huang.b02@gmail.com>
Signed-off-by: Carl Gold <carl@offerfit.ai>
carl-offerfit pushed a commit to carl-offerfit/EconML that referenced this pull request Jul 7, 2025
Signed-off-by: Kuan-Hao Huang <kuan.hao.huang.b02@gmail.com>
Signed-off-by: Carl Gold <carl.goldd@braze.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants