Miscellaneous fixes #939
Merged
Miscellaneous fixes #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
5c7bc4d to
4068916
Compare
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
4068916 to
dcf516f
Compare
kbattocchi
commented
Jan 13, 2025
| @@ -228,10 +228,10 @@ | |||
| # Example configuration for intersphinx: refer to the Python standard library. | |||
| intersphinx_mapping = {'python': ('https://docs.python.org/3', None), | |||
| 'numpy': ('https://numpy.org/doc/stable/', None), | |||
| 'sklearn': ('https://scikit-learn.org/stable/', None), | |||
| 'sklearn': ('https://scikit-learn.org/1.5/', None), | |||
There was a problem hiding this comment.
Even though this PR enables support for sklearn 1.6, that doesn't help here because our docs still build on Python 3.8 (because of the tensorflow dependency for Deep IV), where sklearn 1.5 is the latest version.
We need to specifically link to this version of the sklearn docs because there was a change in the structure of their docs between 1.5 and 1.6, so the mismatch between what we were building against vs. what we were linking to was causing broken links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #938, plus cleans up some other minor issues, including enabling sklearn 1.6 and fixing our documentation builds.