Skip to content

Conversation

kgao
Copy link
Collaborator

@kgao kgao commented Apr 12, 2024

  • This change could lower the failure rate from 4% to Near 0%

Signed-off-by: kgao <kevin.leo.gao@gmail.com>
@kgao kgao self-assigned this Apr 12, 2024
@kgao kgao requested a review from kbattocchi April 12, 2024 22:04
kgao and others added 3 commits May 6, 2024 12:25
@kbattocchi kbattocchi enabled auto-merge (squash) May 7, 2024 05:57
@kbattocchi kbattocchi merged commit ea46d0d into main May 7, 2024
@kbattocchi kbattocchi deleted the fix_test_rscorer branch May 7, 2024 18:24
@kgao kgao changed the title raise threshold to lower the failure rate for rootpehe value assertion. Raise threshold to lower the failure rate for rootpehe value assertion. May 8, 2024
gdaiha pushed a commit to gdaiha/EconML that referenced this pull request May 10, 2024
Increase sample size to reduce errors

Signed-off-by: kgao <kevin.leo.gao@gmail.com>
Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
gdaiha pushed a commit to gdaiha/EconML that referenced this pull request May 10, 2024
Increase sample size to reduce errors

Signed-off-by: kgao <kevin.leo.gao@gmail.com>
Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants