Skip to content

Set default alpha to 0.05 everywhere #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2021
Merged

Set default alpha to 0.05 everywhere #482

merged 4 commits into from
Aug 14, 2021

Conversation

kbattocchi
Copy link
Collaborator

Previously many places were using 0.1, but 0.05 is more standard.

heimengqi
heimengqi approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Have you also checked our notebooks? I feel we will have some place need to update as well (e.g. comments or code)

@kbattocchi kbattocchi force-pushed the kebatt/updateAlpha branch 2 times, most recently from 7f5dd76 to f5821ab Compare August 13, 2021 17:06
@kbattocchi kbattocchi mentioned this pull request Aug 13, 2021
Closed
@kbattocchi kbattocchi enabled auto-merge (rebase) August 13, 2021 17:34
@kbattocchi kbattocchi merged commit fb2d113 into master Aug 14, 2021
@kbattocchi kbattocchi deleted the kebatt/updateAlpha branch August 14, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsyrgkanis vsyrgkanis Awaiting requested review from vsyrgkanis

1 more reviewer

@heimengqi heimengqi heimengqi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbattocchi @heimengqi