Skip to content

Fix the asks function #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2020
Merged

Fix the asks function #131

merged 1 commit into from
Nov 8, 2020

Conversation

setsunica
Copy link
Contributor

@setsunica setsunica commented Sep 16, 2020 •
edited
Loading

Thank you for your response to Issue! 😀
I've made some modifications based on #130.
This is a change to the type definition only.
The constraints are loosened and compatibility with existing sources will be maintained.
Closes #130

hdgarrood
hdgarrood approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be tempted to release this as a breaking change because it’s possible that someone is relying on the more restricted current type signature for type inference to work. It is quite unlikely, admittedly.

@garyb
Copy link
Member

garyb commented Sep 22, 2020

I can't really think of a way this would break an existing inferred type 🤔. Are we going to be breaking this library for 0.14 anyway though? If so, then I guess waiting makes sense.

@hdgarrood
Copy link
Contributor

Here's an example: https://try.purescript.org/?gist=a4db03ecd5e0385e28c493d29f83a686&session=ea0ea2de-a087-ad4b-ec4b-b096e3d090d9

@thomashoneyman
Copy link
Member

Merging as part of upcoming 0.14 changes.

@thomashoneyman thomashoneyman merged commit feca0c8 into purescript:master Nov 8, 2020
@thomashoneyman thomashoneyman mentioned this pull request Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hdgarrood hdgarrood hdgarrood approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify the definition of the asks function of ComonadEnv.
4 participants
@setsunica @garyb @hdgarrood @thomashoneyman