-
Notifications
You must be signed in to change notification settings - Fork 99
Add Apache Shiro integration #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, thanks for the contribution. I'm really not knowledgeable about Shiro but there seems to be no integration code for the framework itself (and actually you don't even need Quasar as a compile dependency for this module at present: a So what's not clear to me is this: which Shiro functionality does the integration allow to be suspendable? [EDIT] Could you also provide some examples/docs? Also, shouldn't the |
Your comments are correct. Shiro allows authentication/authorization functionality via a static method: I'm not yet entirely sure that the static access to Shiro is the right way to go as it makes use ThreadLocal (which, I suspect, retains the correct state in different Quasar actors since Shiro uses an InheritableThreadLocal). But even otherwise, fibered code will be run via the Shiro stack. |
But why the Shiro stack could be suspended in a fiber if your |
I might be missing something. |
I see now, you're calling Don't use If you could also update |
Sure thing. |
You should also agree to contribution terms if you haven't already. Thanks! |
Yep, already did. |
I think I'm done. |
Add Apache Shiro integration
Thanks! |
Hi,
I'm not entirely sure this exhausts all the possible execution paths to Shiro realms, but it seems a good enough start.
Roded