Add #on_stopped DSL (re: discussion/3379)
#3380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
7 tasks
Comment on lines
+722
to
+723
| @options[:on_stopped] ||= [] | ||
| @options[:on_stopped] << block |
There was a problem hiding this comment.
This looks different to other events. And a simple test in config shows it's being ignored completely. On the other hand, delegating this to events seem to work.
Suggested change
| @options[:on_stopped] ||= [] | |
| @options[:on_stopped] << block | |
| @config.options[:events].on_stopped(&block) |
Comment on lines
+476
to
+478
| def test_run_hooks_on_stopped_hook | ||
| assert_run_hooks :on_stopped | ||
| end |
There was a problem hiding this comment.
Given the change above, the test should probably mirror test_on_booted instead.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the
#on_stoppedmethod to Puma's DSL, to match the functionality provided by#on_booted. Since this DSL method is documented, its absence appears to be a simple oversight, and it seems appropriate to have.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.