Lazily require Puma::Rack::Builder
#3340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7380e9 to
1c624a5
Compare
Puma::Rack::Builder
1c624a5 to
686b7e9
Compare
dentarg
approved these changes
Mar 10, 2024
|
Thank you @dentarg |
aramprice
added a commit
to cloudfoundry/bosh
that referenced
this pull request
Nov 25, 2024
This must be explicitly `required` as of `puma` version `6.5.0`. Previousl this class was always loaded by `puma` and this is no longer the case, see: puma/puma#3340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A minor thing I noticed when looking into something unrelated. We seem to always be requiring the builtin rack builder even when it isn't used. This PR ensures that
Puma::Rack::Builderis only required whenRack::Buildercannot be loaded.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.