Skip to content

Conversation

MSP-Greg
Copy link
Member

Description

Recent RuboCop fails with a similar error in four places:

lib/puma/state_file.rb:63:21: C: [Correctable] Performance/StringIdentifierArgument: Use :"#{f}=" instead of "#{f}=".
      define_method "#{f}=" do |v|
                    ^^^^^^^

We've used a string parameter for define_method, but Ruby's docs show it as a symbol. Also, an interpolated symbol could be used, but it's not commonly used, and these aren't 'hot' paths.

Fixed all occurrences.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants