Skip to content

runner.rb - remove ruby_engine method, deprecated Nov-2024 #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

runner.rb - remove ruby_engine method, deprecated Nov-2024 #3701

merged 1 commit into from
Aug 26, 2025

Conversation

MSP-Greg
Copy link
Member

Description

Remove deprecated method from runner.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@github-actions github-actions bot added the waiting-for-review Waiting on review from anyone label Aug 22, 2025
@MSP-Greg
Copy link
Member Author

This failed one job, macs-13, Ruby 3.1, with the dreaded error:

(libev) kqueue kevent: Bad file descriptor
/Users/runner/work/_temp/64681194-7a85-4704-b615-591551234b7c.sh: line 1:  3236 Abort trap: 6

Running again

@schneems schneems merged commit 1acac47 into puma:master Aug 26, 2025
129 of 130 checks passed
@MSP-Greg MSP-Greg deleted the 00-ruby-engine branch August 26, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance waiting-for-review Waiting on review from anyone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSP-Greg @schneems