accept to_path to be nil on bodies #3635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc393a0 to
ad456c8
Compare
|
(CI failures seems unrelated, I have filled socketry/localhost#35) |
|
Could you rebase this? CI is passing now. Also, there are some failures, most due to the issue of 'character' handling vs 'byte' handling. I added two commits to https://github.com/MSP-Greg/puma/commits/00-pr-3535/ which contain changes to the tests and also changes to Old Windows Rubies (2.4 thru 2.6) seem to be failing, so I skipped them. All Windows Rubies from 2.7 and later are passing. |
a9fccf6 to
d43ae7e
Compare
|
Anything still to be done for this PR? |
|
Can we continue looking into this? Currently puma does not follow the rack spec and I need to use a workaround for #3634. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rack spec now supports bodies responding with
nilforto_path.This is the default behavior of IO objects made with
IO.pipe.This PR has a commit to prevent puma from crashing when
to_pathreturns nil.It also has a test for pipe response bodies which tests the presence of this bug.
#3634
rack/rack#2318
Closes #3634
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.