Skip to content

normalize whitespace in worker stats string #3513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

normalize whitespace in worker stats string #3513

merged 1 commit into from
Oct 11, 2024

Conversation

jjb
Copy link
Contributor

@jjb jjb commented Oct 11, 2024

Description

i was making another PR to add another type of stat (busy_threads), and noticed this

it's the heroes like me which keep this project afloat.

Your checklist for this pull request

  • [ x] I have reviewed the guidelines for contributing to this repository.
  • [x ] I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • [x ] My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • [x ] If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • [ x] If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • [x ] I have updated the documentation accordingly.
  • [? ] All new and existing tests passed, including Rubocop.

@jjb
Copy link
Contributor Author

jjb commented Oct 11, 2024

/cc @joshuay03 @dentarg

@jjb
Copy link
Contributor Author

jjb commented Oct 11, 2024

#2473

schneems
schneems approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think of all the whitespace bytes we're able to save!

This is more of a style/refactor which I tend do avoid merging due to conflicts. That being said, normalizing this is nicer and this line doesn't see a lot of churn. Thanks, merging!

@schneems schneems merged commit 9712d29 into puma:master Oct 11, 2024
77 checks passed
@jjb jjb deleted the normalize-whitespace-in-worker-stats branch October 11, 2024 21:42
@jjb
Copy link
Contributor Author

jjb commented Oct 11, 2024

i have a DRYification coming up so we don't have to repeat the stat array twice, and this helps that a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneems schneems schneems approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjb @schneems @dentarg