Skip to content

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Oct 2, 2024

Description

There is currently no test in test_rack_handler for an ssl connection/host.

Add a test, and replace

elsif host && host =~ /^ssl:\/\//

with

elsif host&.start_with? 'ssl://'

in lib/rack/handler/puma.rb

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg changed the title rack/handler/puma.rb = ssl - use start_with?, add test rack/handler/puma.rb - ssl - use start_with?, add test Oct 3, 2024
@MSP-Greg MSP-Greg merged commit 8e7fab5 into puma:master Oct 3, 2024
76 of 77 checks passed
@MSP-Greg MSP-Greg deleted the 00-rack-handler-ssl branch October 3, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants