Fix .env sourcing overwriting existing ENV variables #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potential fix for: #268 This implementation seems simpler than preventing existing ENV variables from being sourced in the first place. Not sure if we should apply the same logic to the other .env file variants as well?
|
Regarding the CI failures, I guess I don't have access to see the logs of those checks. I just see a generic "check failed" message when clicking the Details link. |
Me too. Will restart the jobs. |
|
And now we have a different set of failures 😬 |
yeah, if we're going to do it for one, we should probably do it for all. |
|
I think there's just something funky with GitHub's Big Sur environment... |
|
Closing in favor of #275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for: #268
This implementation seems simpler than preventing existing ENV variables from being sourced in the first place.
Not sure if we should apply the same logic to the other .env file variants as well?