Update go-cloud #3362
Closed
Update go-cloud #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we pre-process the inputs to still support the old format? It would be very nice to not have a breaking change here. |
|
The old input format does not work in any case with CLI 1.5.2, so I think we should expedite this and get a release out. Using CLI 1.5.2, and the docs I get this (names redacted):
$ pulumi stack init --secrets-provider "azurekeyvault://myvault.vault.azure.net/keys/mykey" dev
error: open keeper azurekeyvault://myvault.vault.azure.net/keys/mykey: algorithm is required
$ pulumi stack init --secrets-provider "azurekeyvault://myvault.vault.azure.net/keys/mykey?algorithm=algorithm=RSA-OAEP-256" dev
... (snipped)
dial tcp: lookup myvault.vault.azure.net.vault.azure.net: no such host
$ pulumi stack init --secrets-provider "azurekeyvault://myvault/mykey?algorithm=RSA-OAEP-256" dev
error: secrets (code=PermissionDenied): keyvault.BaseClient#Encrypt: Failure responding to request: StatusCode=401 -- Original Error: autorest/azure: Service returned an error. Status=401 Code="Unauthorized" Message="AKV10022: Invalid audience. Expected https://vault.azure.net, found: https://management.azure.com/."Setting |
|
I believe this has been obviated by #3522. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
gocloud.devto the latest version.This version has some breaking changes. Notably:
secrets/azurekeyvault: Constructor changed, and URLs are nowazurekeyvault://mykevaultname.vault.azure.net/keys/mykeyname/mykeyversioninstead ofazurekeyvault://mykeyvaultname/mykeyname/mykeyversion.See the full list here.
Fixes #3359.