fix some documentation, and change the pv init to not malloc #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandrewstone
commented
Feb 10, 2017
| @@ -34,20 +35,14 @@ void AddScriptCheckThreads(int i, CCheckQueue<CScriptCheck>* pqueue) | |||
|
|
|||
| void AddAllScriptCheckQueuesAndThreads(int nScriptCheckThreads, boost::thread_group* threadGroup) | |||
| { | |||
| vector<CCheckQueue<CScriptCheck>* > vScriptCheckQueue; | |||
There was a problem hiding this comment.
this is not really an important change because this code is not performance related. But the vector STL object is going to malloc and free each time you push_back (or over-malloc). But since this use is a known constant size array, this really good time to use a traditional c array. Personally, I always prefer to use the simplest tool that gets the job done, even though in this case it doesn't really matter from a performance perspective. So this change is not very important to me; take it or leave it, your preference.
ptschip
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.