fix(spinner): suppress spinner line clearing in raw output mode #692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinners with
RawOutput
enabled print lots of blank characters to logs, because the spinners are always callingsClearLine
. Additionally, spinners without any text print several blank newlines to logs.e.g.
This PR suppresses line clearing when
RawOutput
is true, and only writes to the output if there's any text to write.