Skip to content

refactor: use strings.Builder to save memory #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 4, 2024
Merged

refactor: use strings.Builder to save memory #650

merged 4 commits into from
Oct 4, 2024

Conversation

apocelipes
Copy link
Contributor

Fixes #649.

@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 96.93878% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.12%. Comparing base (1a9d517) to head (ac5dc58).
Report is 1 commits behind head on master.

Files Patch % Lines
bulletlist_printer.go 80.00% 2 Missing ⚠️
interactive_select_printer.go 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
+ Coverage   81.05%   81.12%   +0.06%     
==========================================
  Files          33       33              
  Lines        4176     4196      +20     
==========================================
+ Hits         3385     3404      +19     
- Misses        718      719       +1     
  Partials       73       73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MarvinJWendt
MarvinJWendt approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing 🚀

@MarvinJWendt MarvinJWendt changed the title feat: use strings.Builder to save memory refactor: use strings.Builder to save memory Aug 12, 2024
@apocelipes
Copy link
Contributor Author

Hello @MarvinJWendt , thanks for reviewing! I rebased this branch to the latest master, this could make the commit history more clear. All conflict in "table_printer.go" is fixed, you may take some time to review that file again.

@apocelipes apocelipes force-pushed the feat-use-strings-builder branch from 20845df to 3c5a3c1 Compare August 14, 2024 04:10
@apocelipes
Copy link
Contributor Author

I also fixed the linter issues.

@apocelipes apocelipes force-pushed the feat-use-strings-builder branch from 6f818d3 to 9a26d00 Compare August 15, 2024 04:46
@apocelipes
Copy link
Contributor Author

@MarvinJWendt
I think this PR is ready :)

@apocelipes apocelipes force-pushed the feat-use-strings-builder branch 2 times, most recently from e39729a to 9c560f6 Compare August 19, 2024 09:48
@apocelipes
Copy link
Contributor Author

Rebased.

@apocelipes apocelipes force-pushed the feat-use-strings-builder branch from 9c560f6 to d582b75 Compare September 15, 2024 01:27
@MarvinJWendt
Copy link
Member

Sorry for the long wait, I am quite busy with other stuff atm.

@MarvinJWendt MarvinJWendt enabled auto-merge (squash) October 4, 2024 17:03
@MarvinJWendt MarvinJWendt merged commit 668f0d1 into pterm:master Oct 4, 2024
1 of 2 checks passed
@apocelipes apocelipes deleted the feat-use-strings-builder branch October 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinJWendt MarvinJWendt MarvinJWendt approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use strings.Builder to save some memory
2 participants
@apocelipes @MarvinJWendt