Skip to content

Conversation

tomterl
Copy link
Contributor

@tomterl tomterl commented Jun 26, 2024

serde-0.9 no longer has this bug;
testing lsd with a zero-byte colors.yaml works just fine showing the default theme.


TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

serde-0.9 no longer has this bug; 
testing lsd with a zero-byte colors.yaml works just fine showing the default theme.
@tomterl tomterl requested a review from zwpaper as a code owner June 26, 2024 12:31
Copy link

muniu-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tomterl
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot added the size/XS label Jun 26, 2024
@tomterl
Copy link
Contributor Author

tomterl commented Jun 26, 2024

This is a readme only change - how important/possible are the standard todos above?

@zwpaper
Copy link
Member

zwpaper commented Jun 30, 2024

hi @tomterl, good catch! it's ok to ignore them for a doc update

@zwpaper zwpaper merged commit cffa045 into lsd-rs:master Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants