Skip to content

Conversation

zica87
Copy link
Contributor

@zica87 zica87 commented Feb 8, 2024

This flag is added by #840

Copy link

muniu-bot bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zica87

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zwpaper
Copy link
Member

zwpaper commented Feb 11, 2024

good catch @zica87, thanks

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba3666a) 84.48% compared to head (8d68716) 84.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #985   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files          51       51           
  Lines        5067     5067           
=======================================
  Hits         4281     4281           
  Misses        786      786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwpaper zwpaper merged commit 222f573 into lsd-rs:master Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants