Skip to content

Conversation

ar1ja
Copy link
Contributor

@ar1ja ar1ja commented Oct 23, 2023

  • add icons for files for the ash shell
  • add static resources directory icons
  • add android directory icons
  • add bash history icon
  • add packaging icons
  • add cache icons
  • improve the icon for idlerc
  • add java icon
  • add magic files icon
  • add development icons ( like tests directory )
  • add pdb password database icon

TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

- add icons for files for the ash shell
- add static resources directory icons
- add android directory icons
- add bash history icon
- add packaging icons
- add cache icons
- improve the icon for `idlerc`
- add java icon
- add magic files icon
- add development icons ( like `tests` directory )
- add pdb password database icon

Signed-off-by: Ari Archer <ari.web.xyz@gmail.com>
@muniu-bot muniu-bot bot added the size/M label Oct 23, 2023
Signed-off-by: Ari Archer <ari.web.xyz@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #942 (21e8983) into master (36c8f26) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #942   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          51       51           
  Lines        5001     5001           
=======================================
  Hits         4288     4288           
  Misses        713      713           
Files Coverage Δ
src/theme/icon.rs 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@muniu-bot
Copy link

muniu-bot bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TruncatedDinosour

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zwpaper
Copy link
Member

zwpaper commented Oct 29, 2023

the others lgtm, thanks @TruncatedDinosour

Signed-off-by: Ari Archer <ari.web.xyz@gmail.com>
@ar1ja
Copy link
Contributor Author

ar1ja commented Oct 29, 2023

@zwpaper deduped it

@ar1ja ar1ja requested a review from zwpaper October 29, 2023 15:47
@zwpaper zwpaper merged commit 59dc141 into lsd-rs:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants