Skip to content

Added newlines to warning message #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2023
Merged

Added newlines to warning message #869

merged 1 commit into from
Jul 8, 2023

Conversation

juansc
Copy link
Contributor

@juansc juansc commented Jul 7, 2023

Addresses #868. After building

> ./target/release/lsd
Warning: the 'themes' directory is deprecated, use 'colors.yaml' instead.

 build.rs     Cargo.toml     ci           doc       README.md      src      tests
 Cargo.lock   CHANGELOG.md   CODEOWNERS   LICENSE   rustfmt.toml   target

TODO

  • Use cargo fmt
  • Add necessary tests (Not needed)
  • Add changelog entry (Not a significant change)
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@juansc juansc requested review from meain, Peltoche and zwpaper as code owners July 7, 2023 18:53
@muniu-bot
Copy link

muniu-bot bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juansc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zwpaper zwpaper merged commit 58a8723 into lsd-rs:master Jul 8, 2023
@juansc juansc deleted the warning-fix branch July 8, 2023 14:25
@zwpaper zwpaper mentioned this pull request Jul 13, 2023
Closed
1 task
@alichtman alichtman mentioned this pull request Sep 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meain meain Awaiting requested review from meain

@Peltoche Peltoche Awaiting requested review from Peltoche

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juansc @zwpaper