-
Notifications
You must be signed in to change notification settings - Fork 6
Add the strictMode option to not terminate the current ripley session if an invalid HTTP request is received #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eugenepaniot @dwilliams782 I've thought of this before. The reason for the panic
here is to brute force prompt us there is bad input data so that we can take a look at it and fix it, i.e. I think it's useful for ripley to not be resilient here. If we log the error and continue instead, I'm worried we'll never know, unless we explicitly add STDERR checks wherever ripley is used.
If it skips incorrect req and exits with non-zero code, will it be fine? Or input data for ripley has to be properly prepared? |
That would take care of the cronjob finishing in a |
For example
I think it's ok to continue working, in non-critical sections, if possible, but change exitCode. |
Do not break session if got invalid HTTP Method