Skip to content

avoid to update of common_headers #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

avoid to update of common_headers #283

wants to merge 2 commits into from

Conversation

valfa14
Copy link
Contributor

@valfa14 valfa14 commented Oct 25, 2017 •
edited
Loading

close #284

g = Grab()
assert g.config['common_headers'].keys() == Grab().common_headers().keys()
g.setup(headers={"dd": "dd"})
g.go("localhost:8000")
assert g.config['common_headers'].keys() == Grab().common_headers().keys()

@valfa14 valfa14 mentioned this pull request Oct 25, 2017
Closed
@lorien
Copy link
Owner

lorien commented May 4, 2018

Fixed in #336

@lorien lorien closed this May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

headers affects common_headers
2 participants
@valfa14 @lorien