COMPARE TO master

Total Size Diff ⚠️ 📈 +25.68 KB

Hi @gao-sun @darcyYe @wangsijie, just a gentle follow-up on this PR. The changes here would be really helpful for our current workflow, and we’d greatly appreciate your review when you have a moment. Thanks so much for your time and expertise!

@yenharvey Noticed the QQ logo image is quite large and takes ~3s to load on 4G. Could we optimize it (e.g., compress/resize) for faster mobile loading? Thanks!

@cheezone I've reduced the logo size to 2.5k.

Thanks for you contribution

I've addressed all the feedback by adding detailed API comments to the endpoints and functions and removed the duplicate CHANGELOG.md file as it will be auto-generated by the changeset. Thank you!

@yenharvey I noticed that you seem to have already submitted the changes, addressing the review comments. Is it necessary to re-request review?

There seems to be a frozen lockfile issue in your branch. Please take a look at the CI error logs and execute the suggested CLI commands. @yenharvey

@charIeszhao I've executed the suggested command from the CI logs: pnpm install --no-frozen-lockfile to update the lockfile. I noticed that 'logo-dark.svg' was automatically added back during this process. To avoid any further issues, I've decided to keep it rather than removing it again. The updated lockfile and package.json have been pushed to the branch.

@cheezone Yes, this is my first time submitting a PR. I initially started development on the main branch, but later learned it's better practice to use a feature branch for PR development. So I created this new PR with all the changes properly implemented on a dedicated branch. All review comments have been addressed in this PR. I learn the proper workflow. The PR should be ready for review now. Thanks!

@darcyYe Hello, could you please ask if there's a chance for this PR to be reviewed in the near future? This change is quite helpful for me as well, thank you for your hard work!

@yenharvey

It's okay, it's resolved. It was just about the UnionID. However, the QQ connector seems strange to me. It might be a problem with QQ. I did a test on the mobile device. It can't launch the QQ mobile app. Instead, it shows a desktop version page asking the user to scan a QR code. After the user scans the code and agrees, it fails to redirect successfully.

@cheezone Scared me! I thought we were having that awkward "Works only on my machine" situation. This behavior on mobile is actually normal, as my implementation is targeted for web development. I remember mobile needs an extra parameter passed in. Since I wasn't sure if logto had an API to detect platforms, I just temporarily solved the issue of having a QQ connector😜.