Skip to content

fix(editor): incorrect behavior of the delete key for deleting the last char #11190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix(editor): incorrect behavior of the delete key for deleting the last char #11190

merged 1 commit into from
Apr 2, 2024

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Apr 2, 2024

resolve #11188

@xyhp915 xyhp915 requested a review from andelf April 2, 2024 05:09
andelf
andelf approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. It works as expected.

@andelf andelf merged commit 369b5ec into master Apr 2, 2024
@andelf andelf mentioned this pull request Apr 10, 2024
Merged
@tiensonqin tiensonqin deleted the fix/delete-key-behavior branch May 7, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete fails deleting last character of a line
2 participants
@xyhp915 @andelf