Skip to content

Conversation

jramosg
Copy link
Contributor

@jramosg jramosg commented Mar 3, 2024

Old item content was considering that a checkbox is always a [X], but it could also be [x]. So if after replacing the new content this does not change, value is again replaced but now with [x].

@andelf
Copy link
Collaborator

andelf commented Mar 5, 2024

I've refactored your implementation.
Could you help to check if it works as expected?

  • Minor Change: toggle a check box twice will make current [X] become [x], which I think it's the same as Github.

@andelf andelf requested a review from xyhp915 March 5, 2024 08:33
@andelf andelf changed the title Fix #11046 Fix toggling of task list #11046 Mar 5, 2024
@andelf andelf merged commit ce56e78 into logseq:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants