Skip to content

fix(ui): incorrect position for the filter modal on ios platform #10798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix(ui): incorrect position for the filter modal on ios platform #10798

merged 1 commit into from
Jan 3, 2024

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Jan 3, 2024

@xyhp915 xyhp915 requested a review from andelf January 3, 2024 06:52
@xyhp915 xyhp915 requested a review from tiensonqin January 3, 2024 06:52
andelf
andelf approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, LGTM

@tiensonqin tiensonqin merged commit a9fb491 into master Jan 3, 2024
@tiensonqin tiensonqin deleted the fix/modal-ios branch January 3, 2024 09:07
@andelf andelf mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

@tiensonqin tiensonqin Awaiting requested review from tiensonqin

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xyhp915 @andelf @tiensonqin