fix: Highlight page aliases in search results #10761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f22a698 to
0bb16eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10698
Cause of problem
Page aliases were getting formatted in the
cmdk.cljsfile, so when those results were being rendered aslist_item, thetextproperty wasn't a string. Thus, nothing would get highlighted.Proposed solution
A lot of the search result formatting (of headers for blocks and whatnot) are already taking place in the
list_item/v1.cljsfile so we can just move the alias formatting there so that the highlighting works the same as for non-alias results.