Skip to content

Enhance Git auto commit: commit on close, change settings on-the-fly, larger auto commit interval #10536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2024
Merged

Enhance Git auto commit: commit on close, change settings on-the-fly, larger auto commit interval #10536

merged 3 commits into from
Jan 19, 2024

Conversation

ChristianAvila
Copy link
Contributor

@ChristianAvila ChristianAvila commented Nov 23, 2023 •
edited by andelf
Loading

  • Include a switch to enable commit when the user close the window
  • Extend the git commit up to 24 hours

Related conversation in the forums

image

The are a lot of translation missing

UPDATE

@andelf andelf self-requested a review November 27, 2023 07:11
@andelf andelf mentioned this pull request Jan 15, 2024
Merged
@andelf
Copy link
Collaborator

andelf commented Jan 17, 2024 •
edited
Loading

@ChristianAvila Thanks. I've added some more refactoring based on your changeset.

  • Remove the "Restart App to take effect" restriction, now the settings can be changed on the fly
  • Move before-close hook to "close" handler
  • Reverse the setting logic, since "disable" is counterintuitive
  • Event handler debouncer

The title of this Pull Request is also edited.

@andelf andelf changed the title feat: Add new switch to control commit on close and extend the commit seconds Enhance Git auto commit: commit on close, change settings on-the-fly, larger auto commit interval Jan 17, 2024
@ChristianAvila
Copy link
Contributor Author

Thank you, @andelf. I truly appreciate your help.

ChristianAvila and others added 3 commits January 19, 2024 10:09
@andelf
Copy link
Collaborator

andelf commented Jan 19, 2024

Let's ship this. 🚀

@andelf andelf merged commit 095be37 into logseq:master Jan 19, 2024
@andelf
Copy link
Collaborator

andelf commented Jan 19, 2024

It's already included in the nightly release.
https://github.com/logseq/logseq/releases/tag/nightly

@andelf andelf mentioned this pull request Jan 30, 2024
Merged
@turtaf turtaf mentioned this pull request Feb 8, 2024
Closed
2 tasks
@Pxter7777
Copy link

Hi, I'm using 0.10.9 on Windows 10.
Git auto commit in fixed interval works fine for me, but the "Git commit on window close" doesn't, Logseq won't commit after I close it, is it a bug or did I misunderstand the feature?

@ChristianAvila ChristianAvila deleted the git-on-close branch September 3, 2024 23:25
@ChristianAvila
Copy link
Contributor Author

Hi @Pxter7777, I tested the feature only on MacOS, and it works as expected. I'm not sure if the window manager behaves differently on Windows, but on MacOS, when you "close" the app, it continues running in the background. During that time, Logseq creates the commit.

* 918427b - (HEAD -> master) Auto saved by Logseq (3 minutes ago) <ChristianAvila>
* b53513f - Auto saved by Logseq (3 minutes ago) <ChristianAvila>
* 5c35fea - Auto saved by Logseq (3 minutes ago) <ChristianAvila>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

@tiensonqin tiensonqin Awaiting requested review from tiensonqin

@xyhp915 xyhp915 Awaiting requested review from xyhp915

@logseq-cldwalker logseq-cldwalker Awaiting requested review from logseq-cldwalker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it possible to configure longer commit intervals or auto combine many local commits into single one on daily basis?
3 participants
@ChristianAvila @andelf @Pxter7777