Skip to content

Conversation

YU000jp
Copy link
Contributor

@YU000jp YU000jp commented Aug 17, 2023

#5961 Still unresolved, this bug involves utilizing useInView hook to track if elements are within the visible screen. Yet, this leads to persistent monitoring even after the initial display, creating a cycle of observation during visibility toggling. Consequently, excessive scrolling ensues, causing notable CPU resource consumption.(#9963 (comment)) The recommended approach is to terminate monitoring once elements are initially displayed.

Change

  • Trigger-once? false > true

@YU000jp YU000jp changed the title fix(bug): Main scrollbar jumps #5961 set initially visible fix(bug): Main scrollbar jumps #5961 (process once only) Aug 17, 2023
@YU000jp YU000jp changed the title fix(bug): Main scrollbar jumps #5961 (process once only) mistake ~~fix(bug): Main scrollbar jumps #5961 (process once only)~~ Aug 18, 2023
@YU000jp YU000jp changed the title mistake ~~fix(bug): Main scrollbar jumps #5961 (process once only)~~ fix(bug): Main scrollbar jumps #5961 (process once only) Aug 18, 2023
@andelf
Copy link
Collaborator

andelf commented Feb 21, 2024

Before:
image

After:
image

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit ab74c1e into logseq:master Feb 21, 2024
@YU000jp
Copy link
Contributor Author

YU000jp commented Feb 21, 2024

Thank you.

I tried it locally, but I'm not sure - if I was able to fully check all the functions. It is necessary to check the operation as it affects blocks and pages transitions.

@YU000jp YU000jp mentioned this pull request Mar 21, 2024
2 tasks
@YU000jp YU000jp deleted the lazyloading branch March 21, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants