Skip to content

Conversation

ONLY-yours
Copy link
Collaborator

@ONLY-yours ONLY-yours commented Jul 28, 2025

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

Summary by Sourcery

Bug Fixes:

  • Remove width: '0' from the Desktop layout container style to prevent the settings window from disappearing on desktop

Copy link

vercel bot commented Jul 28, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Updated (UTC)
lobe-chat-preview ๐Ÿ”„ Building (Inspect) Visit Preview Jul 28, 2025 8:35am

Copy link
Contributor

sourcery-ai bot commented Jul 28, 2025

Reviewer's Guide

The PR resolves an issue where the desktop settings layout was not visible by removing the fixed zero width restriction, allowing the container to expand via flexbox as intended.

Class diagram for Desktop Layout style fix

classDiagram
    class Layout {
        +children
        +category
        +ref
        +theme
        +md
        +style // style prop changed: removed width: '0'
    }
Loading

File-Level Changes

Change Details Files
Removed explicit zero width on the settings container to restore visibility
  • Deleted width: '0' from the style prop
  • Ensured the container relies on flex: 1 for sizing
src/app/[variants]/(main)/settings/_layout/Desktop/index.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

gru-agent bot commented Jul 28, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 6106498 ๐Ÿšซ Skipped No files need to be tested {"src/app/[variants]/(main)/settings/_layout/Desktop/index.tsx":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@lobehubbot
Copy link
Member

๐Ÿ‘ @ONLY-yours

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ๐Ÿ’„ Design Design an style | ๆ ทๅผ้—ฎ้ข˜ labels Jul 28, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ONLY-yours - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them โœจ
Help me be more useful! Please click ๐Ÿ‘ or ๐Ÿ‘Ž on each comment and I'll use the feedback to improve your reviews.

@arvinxx arvinxx merged commit 74ab822 into main Jul 28, 2025
29 of 31 checks passed
@arvinxx arvinxx deleted the fix/settingPannelWidth branch July 28, 2025 08:37
@lobehubbot
Copy link
Member

โค๏ธ Great PR @ONLY-yours โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โœ… Project coverage is 85.58%. Comparing base (4902341) to head (6106498).
โš ๏ธ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8585   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files         909      909           
  Lines       69073    69073           
  Branches     4531     4531           
=======================================
  Hits        59114    59114           
  Misses       9959     9959           
Flag Coverage ฮ”
app 85.58% <รธ> (รธ)
server 96.26% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions bot pushed a commit that referenced this pull request Jul 28, 2025
### [Version&nbsp;1.104.5](v1.104.4...v1.104.5)
<sup>Released on **2025-07-28**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Fix setting window layout when in desktop was disappear.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Fix setting window layout when in desktop was disappear, closes [#8585](#8585) ([74ab822](74ab822))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.104.5 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to jaworldwideorg/OneJA-Bot that referenced this pull request Jul 28, 2025
## [Version&nbsp;1.104.0](v1.103.3...v1.104.0)
<sup>Released on **2025-07-28**</sup>

#### โœจ Features

- **misc**: Implement API Key management functionality, support custom hotkey on desktop.

#### ๐Ÿ› Bug Fixes

- **misc**: Fix update hotkey invalid when input mod in desktop, update convertUsage to handle XAI provider and adjust OpenAIStream to pass provider.

#### ๐Ÿ’„ Styles

- **misc**: Add Gemini 2.5 Flash-Lite GA model, fix setting window layout size, fix setting window layout when in desktop was disappear, update i18n.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Implement API Key management functionality, closes [lobehub#8535](https://github.com/jaworldwideorg/OneJA-Bot/issues/8535) ([fdaa725](fdaa725))
* **misc**: Support custom hotkey on desktop, closes [lobehub#8559](https://github.com/jaworldwideorg/OneJA-Bot/issues/8559) ([b50f121](b50f121))

#### What's fixed

* **misc**: Fix update hotkey invalid when input mod in desktop, closes [lobehub#8572](https://github.com/jaworldwideorg/OneJA-Bot/issues/8572) ([07f3e6a](07f3e6a))
* **misc**: Update convertUsage to handle XAI provider and adjust OpenAIStream to pass provider, closes [lobehub#8557](https://github.com/jaworldwideorg/OneJA-Bot/issues/8557) ([d1e4a54](d1e4a54))

#### Styles

* **misc**: Add Gemini 2.5 Flash-Lite GA model, closes [lobehub#8539](https://github.com/jaworldwideorg/OneJA-Bot/issues/8539) ([404ac21](404ac21))
* **misc**: Fix setting window layout size, closes [lobehub#8483](https://github.com/jaworldwideorg/OneJA-Bot/issues/8483) ([4902341](4902341))
* **misc**: Fix setting window layout when in desktop was disappear, closes [lobehub#8585](https://github.com/jaworldwideorg/OneJA-Bot/issues/8585) ([74ab822](74ab822))
* **misc**: Update i18n, closes [lobehub#8579](https://github.com/jaworldwideorg/OneJA-Bot/issues/8579) ([2eccbc7](2eccbc7))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
bbbugg pushed a commit to bbbugg/lobe-chat that referenced this pull request Aug 14, 2025
### [Version&nbsp;1.104.5](lobehub/lobe-chat@v1.104.4...v1.104.5)
<sup>Released on **2025-07-28**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Fix setting window layout when in desktop was disappear.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Fix setting window layout when in desktop was disappear, closes [lobehub#8585](lobehub#8585) ([45c6a00](lobehub@45c6a00))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
cy948 pushed a commit to cy948/lobe-chat that referenced this pull request Aug 23, 2025
### [Version&nbsp;1.104.5](lobehub/lobe-chat@v1.104.4...v1.104.5)
<sup>Released on **2025-07-28**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Fix setting window layout when in desktop was disappear.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Fix setting window layout when in desktop was disappear, closes [lobehub#8585](lobehub#8585) ([74ab822](lobehub@74ab822))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ’„ Design Design an style | ๆ ทๅผ้—ฎ้ข˜ released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants