-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
💄 style: fix MiniMax-M1
reasoning tag missing
#8240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hezhijie0327 is attempting to deploy a commit to the LobeHub Community Team on Vercel. A member of the Team first needs to authorize it. |
Reviewer's GuideRestored the missing reasoning flag on Class diagram for updated AIChatModelCard structure in minimax.tsclassDiagram
class AIChatModelCard {
abilities: Abilities
contextWindowTokens: number
description: string
displayName: string
id: string
maxOutput: number
pricing: Pricing
settings: Settings
type: string
}
class Abilities {
functionCall: boolean
reasoning: boolean
search: boolean
vision: boolean
}
class Pricing {
currency: string
input: number
output: number
}
class Settings {
searchImpl: string
}
AIChatModelCard --> Abilities
AIChatModelCard --> Pricing
AIChatModelCard --> Settings
%% Highlighted change: reasoning added to abilities for MiniMax-M1
%% Removed: DeepSeek-R1 and abab6.5s-chat models from minimaxChatModels array
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hezhijie0327 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8240 +/- ##
==========================================
- Coverage 95.67% 87.86% -7.82%
==========================================
Files 14 836 +822
Lines 2522 62318 +59796
Branches 445 5866 +5421
==========================================
+ Hits 2413 54754 +52341
- Misses 109 7564 +7455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❤️ Great PR @hezhijie0327 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.96.1](v1.96.0...v1.96.1) <sup>Released on **2025-06-21**</sup> #### 🐛 Bug Fixes - **misc**: Fix `MiniMax-M1` reasoning tag missing. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix `MiniMax-M1` reasoning tag missing, closes [#8240](#8240) ([ea76c11](ea76c11)) </details> <div align="right"> [](#readme-top) </div>
🎉 This PR is included in version 1.96.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [Version 1.95.0](v1.94.5...v1.95.0) <sup>Released on **2025-06-25**</sup> #### ✨ Features - **misc**: Add Brave & Google PSE & Kagi as build-in Search Provider, add v0 (Vercel) provider support. #### 🐛 Bug Fixes - **misc**: Fix `MiniMax-M1` reasoning tag missing, fix inputTemplate behavior, Google Gemini tools declarations, Remove unsupported parameters of Hunyuan. #### 💄 Styles - **openrouter**: Add stable versions of Gemini 2.5 models. - **misc**: Add `blockAds` & `stealth` params for Browserless, Optimized Gemini thinkingBudget configuration, update i18n, update i18n. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add Brave & Google PSE & Kagi as build-in Search Provider, closes [lobehub#8172](https://github.com/jaworldwideorg/OneJA-Bot/issues/8172) ([16ae521](16ae521)) * **misc**: Add v0 (Vercel) provider support, closes [lobehub#8235](https://github.com/jaworldwideorg/OneJA-Bot/issues/8235) ([5842a18](5842a18)) #### What's fixed * **misc**: Fix `MiniMax-M1` reasoning tag missing, closes [lobehub#8240](https://github.com/jaworldwideorg/OneJA-Bot/issues/8240) ([ea76c11](ea76c11)) * **misc**: Fix inputTemplate behavior, closes [lobehub#8204](https://github.com/jaworldwideorg/OneJA-Bot/issues/8204) ([61c2c3c](61c2c3c)) * **misc**: Google Gemini tools declarations, closes [lobehub#8256](https://github.com/jaworldwideorg/OneJA-Bot/issues/8256) ([08f5d73](08f5d73)) * **misc**: Remove unsupported parameters of Hunyuan, closes [lobehub#8247](https://github.com/jaworldwideorg/OneJA-Bot/issues/8247) ([826d724](826d724)) #### Styles * **openrouter**: Add stable versions of Gemini 2.5 models, closes [lobehub#8239](https://github.com/jaworldwideorg/OneJA-Bot/issues/8239) ([d34ecab](d34ecab)) * **misc**: Add `blockAds` & `stealth` params for Browserless, closes [lobehub#8255](https://github.com/jaworldwideorg/OneJA-Bot/issues/8255) ([2ff3efa](2ff3efa)) * **misc**: Optimized Gemini thinkingBudget configuration, closes [lobehub#8224](https://github.com/jaworldwideorg/OneJA-Bot/issues/8224) ([03625e8](03625e8)) * **misc**: Update i18n, closes [lobehub#8253](https://github.com/jaworldwideorg/OneJA-Bot/issues/8253) ([b86dc9b](b86dc9b)) * **misc**: Update i18n, closes [lobehub#8242](https://github.com/jaworldwideorg/OneJA-Bot/issues/8242) ([2d1babc](2d1babc)) </details> <div align="right"> [](#readme-top) </div>
### [Version 1.96.1](lobehub/lobe-chat@v1.96.0...v1.96.1) <sup>Released on **2025-06-21**</sup> #### 🐛 Bug Fixes - **misc**: Fix `MiniMax-M1` reasoning tag missing. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix `MiniMax-M1` reasoning tag missing, closes [lobehub#8240](lobehub#8240) ([ea76c11](lobehub@ea76c11)) </details> <div align="right"> [](#readme-top) </div>
### [Version 1.96.1](lobehub/lobe-chat@v1.96.0...v1.96.1) <sup>Released on **2025-06-21**</sup> #### 🐛 Bug Fixes - **misc**: Fix `MiniMax-M1` reasoning tag missing. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix `MiniMax-M1` reasoning tag missing, closes [lobehub#8240](lobehub#8240) ([7b396cf](lobehub@7b396cf)) </details> <div align="right"> [](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
MiniMax-M1
Reasoning 标签丢失📝 补充信息 | Additional Information
ref: https://platform.minimaxi.com/document/%E5%AF%B9%E8%AF%9D?key=66701d281d57f38758d581d0#QklxsNSbaf6kM4j6wjO5eEek
Summary by Sourcery
Fix the missing reasoning flag on the MiniMax-M1 model and clean up obsolete model entries from the configuration
Bug Fixes:
Enhancements:
abab6.5s-chat
andDeepSeek-R1
models per API documentation