Skip to content

Make localstack an implicit namespace package #11190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2024
Merged

Make localstack an implicit namespace package #11190

merged 2 commits into from
Jul 15, 2024

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Jul 12, 2024 •
edited
Loading

Motivation

To allow us to introduce namespace packages downstream like localstack.pro.core or localstack.pro.aws, we need to first make localstack itself a namespace package.

Changes

TODO

What's left to do:

  • Check if anything breaks => caching the venv was breaking the pro integration tests

@dominikschubert dominikschubert self-assigned this Jul 12, 2024
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Jul 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 29s ⏱️
404 tests 352 ✅  52 💤 0 ❌
808 runs  704 ✅ 104 💤 0 ❌

Results for commit bfe1a4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 33m 33s ⏱️ - 2m 53s
3 180 tests ±0  2 779 ✅ ±0  401 💤 ±0  0 ❌ ±0 
3 182 runs  ±0  2 779 ✅ ±0  403 💤 ±0  0 ❌ ±0 

Results for commit bfe1a4e. ± Comparison against base commit d343815.

♻️ This comment has been updated with latest results.

@dominikschubert dominikschubert marked this pull request as ready for review July 12, 2024 13:43
alexrashed
alexrashed approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Kudos to you and to @thrau for the great preparation leading to this super-small change which at the same time will have quite an impact on how we structure and build LocalStack in the future! 💯🦸🤩

@dominikschubert dominikschubert merged commit 1673c89 into master Jul 15, 2024
43 checks passed
@dominikschubert dominikschubert deleted the namespace-package branch July 15, 2024 08:48
This was referenced Jul 15, 2024
Merged
Merged
Closed
Merged
Merged
Merged
Merged
@alexrashed alexrashed mentioned this pull request Aug 14, 2024
Merged
9 tasks
@dfangl dfangl mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau Awaiting requested review from thrau

@simonrw simonrw Awaiting requested review from simonrw

@dfangl dfangl Awaiting requested review from dfangl

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikschubert @alexrashed