patch HTTPServer fixture to spawn daemon thread #10052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files 2 suites 1h 16m 55s ⏱️ For more details on these failures, see this check. Results for commit 4d8adab. |
dominikschubert
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
LGTM, seems to be a sensible solution for now to at least not block the CI action after test execution finished. We'll still need to get to the bottom of why this is leaking but It's not extremely urgent, but let's open a follow-up PR that reverts this immediately after merge so we don't forget about it
This was referenced Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've had issue with the pipeline timing out very frequently for the community tests against Pro.
It seems all test runs timing out had a leftover thread in common, spawned by the
httpserverfixture.This thread was not spawned as
daemon, meaning it would prevent the interpreter from shutting down.Changes
Temporary fix: patch the fixture to spawn the thread as daemon, so that even if it's still running, we can force its removal.
Next up