[ARM] Add writeback information to STC and LDC instructions. #67180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
23df255 to
a059c29
Compare
XVilka
suggested changes
Sep 25, 2023
a059c29 to
3912ef0
Compare
XVilka
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Failure seems unrelated:
FAILED: unittests/tools/llvm-profgen/LLVMProfgenTests.exe
--
| cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --intdir=unittests\tools\llvm-profgen\CMakeFiles\LLVMProfgenTests.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests -- C:\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\link.exe /nologo unittests\tools\llvm-profgen\CMakeFiles\LLVMProfgenTests.dir\ContextCompressionTest.cpp.obj unittests\tools\llvm-profgen\CMakeFiles\LLVMProfgenTests.dir\__\__\__\resources\windows_version_resource.rc.res /out:unittests\tools\llvm-profgen\LLVMProfgenTests.exe /implib:unittests\tools\llvm-profgen\LLVMProfgenTests.lib /pdb:unittests\tools\llvm-profgen\LLVMProfgenTests.pdb /version:0.0 /machine:x64 /STACK:10000000 /INCREMENTAL:NO /subsystem:console lib\LLVMSupport.lib lib\LLVMSupport.lib lib\llvm_gtest_main.lib lib\llvm_gtest.lib lib\LLVMTestingSupport.lib lib\llvm_gtest.lib lib\LLVMSupport.lib psapi.lib shell32.lib ole32.lib uuid.lib advapi32.lib delayimp.lib -delayload:shell32.dll -delayload:ole32.dll lib\LLVMDemangle.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
| MT: command "C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe /nologo /manifest unittests\tools\llvm-profgen\LLVMProfgenTests.exe.manifest /outputresource:unittests\tools\llvm-profgen\LLVMProfgenTests.exe;#1" failed (exit code 0x1f) with the following output:
|
| mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "unittests\tools\llvm-profgen\LLVMProfgenTests.exe". Operation did not complete successfully because the file contains a virus or potentially unwanted software.
| [9679/9687] Linking CXX executable unittests\tools\llvm-exegesis\LLVMExegesisTests.exe
| [9681/9687] Linking CXX executable tools\clang\unittests\Tooling\ToolingTests.exe
| ninja: build stopped: subcommand failed.
|
Ping? |
|
It is still on the todo list. Sorry for letting it run stale. Will update it soon. |
|
I will eventually come back to this. But currently I won't find time to finish this. We accumulated a few other LLVM fixes in Capstone anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDCandSTCwere missing the write-back register.