Add SitestBlackBoxLibrariesAnnotation; process in CreateSiFiveMetadataPass #8670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
The implementation generally looks good to me. Just a couple style nits. @prithayan since you're familiar with this, do you mind taking a look?
tmckay-sifive
commented
Jul 8, 2025
prithayan
approved these changes
Jul 8, 2025
|
I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows extmodules to be annotated with additional library names to be included in the blackbox metadata. Downstream tooling can consume this to determine additional libraries that should be compiled alongside extmodules.