[FIRRTL] Fix inject-dut-hier deleting new top #8678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue with the `moveDut=true` behavior of the `InjectDUTHierarchy` pass that would occur if the design-under-test (DUT) was the main module in a circuit. If this happens, this would create a new wrapper module above the DUT, mark it private, and keep the main module of the circuit pointing at the wrapper. This would then cause the new DUT to be deleted as it was a private module. This is not FIRRTL ABI compatible as it will create a new public module and cause things like additional ref files to be created. CC: @azidar Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with the
moveDut=truebehavior of theInjectDUTHierarchypass that would occur if the design-under-test (DUT) was the main module
in a circuit. If this happens, this would create a new wrapper module
above the DUT, mark it private, and keep the main module of the circuit
pointing at the wrapper. This would then cause the new DUT to be deleted
as it was a private module.
This is not FIRRTL ABI compatible as it will create a new public module
and cause things like additional ref files to be created.
CC: @azidar