[importverilog] Lvalue RangelSelect and ElementSelect to use range. #8663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it uniform with how the RvalueExprVisitor handles it. Resolves: llvm#8657
|
Thanks! Could you add a test to https://github.com/llvm/circt/blob/main/test/Conversion/ImportVerilog/basic.sv? |
|
Done, could do it simpler than expected by just checking write and read indices match. |
fabianschuiki
approved these changes
Jul 8, 2025
|
I was just running circt-verilog on a few internal design snippets and noticed that your fix here got rid of a lot of LEC mismatches I was seeing. Thanks 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it uniform with how the RvalueExprVisitor handles it (copied getSelectIndex verbatim, could also make utility function shared between visitors).
Resolves: #8657