-
Notifications
You must be signed in to change notification settings - Fork 366
[FIRRTL] Delete BlackBoxResourceFileNameAnno #8669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIRRTL] Delete BlackBoxResourceFileNameAnno #8669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! CIRCT 1 : Bit-Rot 0.
Remove `BlackBoxResourceFileNameAnno` since this has not been load beagin after it was removed from Chisel [[1]]. This annotation was used to control the name of a file which was produced that listed all blackboxes in the design. Instead, use the default name always. Note: I plan to remove this file entirely in a follow-on as this appears to be completely unused. [1]: chipsalliance/chisel@70f5c70 Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Remove the generation of `firrtl_black_box_resource_files.f`. This file was originally controllable by the `BlackBoxResourceFileNameAnno`, but that has since been removed. This file is, additionally, no longer load bearing and can be completely dropped. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
ade0d90
to
c7e10d7
Compare
@seldridge after removing |
@tymcauley: Do you need to know the names of any of the generated blackboxes given that these will always show up in one of the output build directories? I.e., Note: I'm spitballing this here as I dropped this without much concern for existing users. 😬 Are you using this currently and how are you using it? |
Ya, I just need to know the names of those generated blackbox files. Right now, they're showing up in my output directory along with all of the other generated SystemVerilog files. I'm using a build system similar to what Chipyard does: https://github.com/ucb-bar/chipyard/blob/973f8732d4ffeb8cc231edf109e84eef114e3d6e/common.mk#L188 Is there a way to place all of the blackbox files defined in Chisel into a subdirectory of the |
Note: I am entirely fine with reverting this if we need to! However, if dropping this shakes out a simpler solution with fewer ways of doing things that would be good. 😉 |
Okay, that annotation looks like it should do the trick, thanks! For the path provided in that annotation, can it be a relative path, and I'm assuming it would be relative to wherever |
Yes, it can be relative. It should be relative to the |
This breaks upstream Chisel as it relies on this file to find blackboxes through logic here: https://github.com/chipsalliance/chisel/blob/177579fe6159217b607d898ee5180445627a4427/src/main/scala/chisel3/simulator/package.scala#L236 I will plan to update svsim so that this will continue to work. svsim really shouldn't be relying on these undocumented filelists. |
I also ran into #8672 while trying to experiment with |
This is two logical commits:
Remove
BlackBoxResourceFileNameAnno
since this has not been load beaginafter it was removed from Chisel [1]. This annotation was used to control
the name of a file which was produced that listed all blackboxes in the
design. Instead, use the default name always.
Completely remove the generation of the vestigial
firrtl_black_box_resource_files.f
. This file is intended to be unused bydownstream flows.