[RTG] Add LowerValidateToLabels pass #8666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
approved these changes
Jul 8, 2025
| builder.create<rtg::LabelOp>(loc, rtg::LabelVisibility::global, lbl); | ||
| validateOp.getValue().replaceAllUsesWith(validateOp.getDefaultValue()); | ||
|
|
||
| pruner.eraseNow(validateOp); |
There was a problem hiding this comment.
nit: Strictly speaking it's not allowed to erase operations in walk other than the current operation (validateOp). Though I think it's always legal with the current implementation of walk specifically.
There was a problem hiding this comment.
This call only erases the validateOp and remembers now unused operations defining the operands in the eraseNow call below.
There was a problem hiding this comment.
Oh, thanks. I misunderstood that eraseNow walks and erases operations transitively....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pass to be run in the first compilation run to generate sideband command labels understood by the ISA simulator (e.g. Spike).