Skip to content

[RTG] Add EmbedValidationValuesPass #8648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

[RTG] Add EmbedValidationValuesPass #8648

merged 1 commit into from
Jul 7, 2025

Conversation

maerhart
Copy link
Member

@maerhart maerhart commented Jul 3, 2025

No description provided.

@maerhart maerhart added the RTG Involving the `rtg` dialect label Jul 3, 2025
uenoku
uenoku reviewed Jul 3, 2025
View reviewed changes
uenoku
uenoku reviewed Jul 3, 2025
View reviewed changes
uenoku
uenoku approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@uenoku uenoku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than few nits.

fabianschuiki
fabianschuiki approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maerhart maerhart force-pushed the maerhart-rtg-embed-validation-values branch from 436d2d8 to 09140c9 Compare July 7, 2025 14:10
@maerhart maerhart merged commit 587474b into main Jul 7, 2025
7 checks passed
@maerhart maerhart deleted the maerhart-rtg-embed-validation-values branch July 7, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@uenoku uenoku uenoku approved these changes

@rwy7 rwy7 Awaiting requested review from rwy7

@youngar youngar Awaiting requested review from youngar

@darthscsi darthscsi Awaiting requested review from darthscsi

Assignees
No one assigned
Labels
RTG Involving the `rtg` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maerhart @fabianschuiki @uenoku