[ExportVerilog] Add support for hw.array_inject #8645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
reviewed
Jul 2, 2025
Extend the PrepareForEmission part of ExportVerilog to lower
`hw.array_inject` into a bit of procedural Verilog code that overwrites
the injected array index:
```systemverilog
// %b = hw.array_inject %a[%i], %v
logic [N-1:0] b;
always_comb begin
b = a;
b[i] = v;
end
```
Unfortunately assignment patterns like `'{0: x, 1: y, 2: z}` only
support constant expressions for the array indices. The only options to
mutate a single array entry that I am aware of are the procedural style
implement in this commit, and creating a separate mux/ternary op for
each index separately, which feels like total overkill.
137f786 to
dbcf4f7
Compare
|
Excellent point @uenoku! I've added a few tests to make sure the expressions get pulled out of procedural regions as expected when local variables are disallowed, and that the lowering works within procedural regions as well. |
uenoku
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the PrepareForEmission part of ExportVerilog to lower
hw.array_injectinto a bit of procedural Verilog code that overwrites the injected array index:Unfortunately assignment patterns like
'{0: x, 1: y, 2: z}only support constant expressions for the array indices. The only options to mutate a single array entry that I am aware of are the procedural style implement in this commit, and creating a separate mux/ternary op for each index separately, which feels like total overkill.