[PyCDE] Improve location information #8635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move from single location to stack - Add location to a bunch of places it was missing
There was a problem hiding this comment.
Pull Request Overview
This PR enhances how PyCDE captures and reports source locations by switching from a single location to a stack-based callsite and annotating many IR operations with the new location information.
- Rewrote
get_user_locto accumulate a stack of user frames and emit a callsite location. - Added
loc=get_user_loc()arguments to MLIR operation constructors across multiple modules. - Updated hidden filenames set to skip
support.pyalong withfunctools.py.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontends/PyCDE/src/pycde/support.py | Reworked location extractor to build a stack, updated hidden files. |
| frontends/PyCDE/src/pycde/signals.py | Annotated BitcastOp with loc=get_user_loc(). |
| frontends/PyCDE/src/pycde/esi.py | Added loc parameters to various ESI service operations. |
| frontends/PyCDE/src/pycde/bsp/cosim.py | Imported get_user_loc and added loc to top-level cosim op. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the location information emitted from PyCDE.