[Seq] Fix FirMemReadWriteOp::canonicalize #5460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The canonicalizer no longer accesses the op after it has been erased.
Merged
seldridge
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Nice.
An alternative would be to do a 4-step process of:
- Create the new
FirMemReadOp(notreplaceOpWithNewOp). - Copy over the attributes.
- RAUW
- Erase the old op.
The cost of the temporary is basically free here as these temporaries are ArrayRef<NamedAttribute> and ArrayRef<StringRef>. I think that this is safe as everything backing those refs should be in interned storage. However, I'm not totally sure.
|
Awesome! Thanks a lot for the quick fix 💯. Totally missed that during testing 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canonicalizer no longer accesses the op after it has been erased.